Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-SNOW Update Kafka dependencies to 3.9.0 #1020

Closed
wants to merge 1 commit into from
Closed

NO-SNOW Update Kafka dependencies to 3.9.0 #1020

wants to merge 1 commit into from

Conversation

sfc-gh-mbobowski
Copy link
Contributor

@sfc-gh-mbobowski sfc-gh-mbobowski commented Dec 4, 2024 •
edited
Loading

Overview

NO-SNOW

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

@sfc-gh-mbobowski sfc-gh-mbobowski requested a review from a team as a code owner December 4, 2024 20:41
@sfc-gh-mbobowski sfc-gh-mbobowski enabled auto-merge (squash) December 4, 2024 20:49
@sfc-gh-mbobowski
Copy link
Contributor Author

ITs using embedded Kafka Connect fails on 3.9.0:

java.lang.NoClassDefFoundError: org/apache/kafka/server/fault/MockFaultHandler

	at kafka.testkit.KafkaClusterTestKit$SimpleFaultHandlerFactory.<init>(KafkaClusterTestKit.java:129)
	at kafka.testkit.KafkaClusterTestKit$Builder.<init>(KafkaClusterTestKit.java:153)
	at org.apache.kafka.connect.util.clusters.EmbeddedKafkaCluster.<init>(EmbeddedKafkaCluster.java:126)
	at org.apache.kafka.connect.util.clusters.EmbeddedConnect.<init>(EmbeddedConnect.java:81)
	at org.apache.kafka.connect.util.clusters.EmbeddedConnectCluster.<init>(EmbeddedConnectCluster.java:75)
	at org.apache.kafka.connect.util.clusters.EmbeddedConnectCluster.<init>(EmbeddedConnectCluster.java:50)
	at org.apache.kafka.connect.util.clusters.EmbeddedConnectCluster$Builder.build(EmbeddedConnectCluster.java:221)
	at org.apache.kafka.connect.util.clusters.EmbeddedConnectCluster$Builder.build(EmbeddedConnectCluster.java:191)
	at org.apache.kafka.connect.util.clusters.EmbeddedConnectBuilder.build(EmbeddedConnectBuilder.java:76)
	at com.snowflake.kafka.connector.ConnectClusterBaseIT.beforeAll(ConnectClusterBaseIT.java:42)
	at java.lang.reflect.Method.invoke(Method.java:498)

I couldn't resolve what happened with this class so for now I skip updating Kafka.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-rsawicki sfc-gh-rsawicki sfc-gh-rsawicki approved these changes

@sfc-gh-dseweryn sfc-gh-dseweryn sfc-gh-dseweryn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-mbobowski @sfc-gh-dseweryn @sfc-gh-rsawicki